refactor(starknet_api): change default sierra contract class to valid one #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Dec 3, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
AvivYossef-starkware
requested review from
dorimedini-starkware and
Yoni-Starkware
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
+ Coverage 40.10% 45.87% +5.77%
==========================================
Files 26 30 +4
Lines 1895 3093 +1198
Branches 1895 3093 +1198
==========================================
+ Hits 760 1419 +659
- Misses 1100 1608 +508
- Partials 35 66 +31 ☔ View full report in Codecov by Sentry. |
dorimedini-starkware
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)
AvivYossef-starkware
changed the base branch from
aviv/add_sierra_version
to
graphite-base/2439
AvivYossef-starkware
force-pushed
the
graphite-base/2439
branch
from
aa5b760 to
1083f6b
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_default_sierra_contract_class
branch
from
8621e48 to
5ad2c5b
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_default_sierra_contract_class
branch
from
5ad2c5b to
e4da175
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.