Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(papyrus_storage): add sierra version to papyrus cache #2438

Merged
merged 1 commit into from
Dec 15, 2024
Merged

feat(papyrus_storage): add sierra version to papyrus cache #2438

merged 1 commit into from
Dec 15, 2024

Conversation

AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 3, 2024
Merged
@AvivYossef-starkware Graphite App
Copy link
Contributor Author

AvivYossef-starkware commented Dec 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 3, 2024
Draft
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Artifacts upload workflows:

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 7f7dbe8 to 3de0987 Compare December 3, 2024 15:32
@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 3, 2024 15:33
@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 3, 2024
Merged
dorimedini-starkware
dorimedini-starkware approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)

a discussion (no related file):
General remark: I have a feeling the size of the sierra version cache should be identical to the size of the sierra contract cache -when will you want a version with the class / a class without the version?

Yoni-Starkware
Yoni-Starkware requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @TzahiTaub)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

General remark: I have a feeling the size of the sierra version cache should be identical to the size of the sierra contract cache -when will you want a version with the class / a class without the version?

Blocking - this PR is not relevant, we're going to have a cache for the Sierra classes.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 3de0987 to 5f9927f Compare December 4, 2024 09:35
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (aviv/get_versioned_casm@6172e4d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/papyrus_state_reader/src/papyrus_state.rs 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                    Coverage Diff                     @@
##             aviv/get_versioned_casm    #2438   +/-   ##
==========================================================
  Coverage                           ?   60.25%           
==========================================================
  Files                              ?      180           
  Lines                              ?    20780           
  Branches                           ?    20780           
==========================================================
  Hits                               ?    12522           
  Misses                             ?     7426           
  Partials                           ?      832

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch 2 times, most recently from f9fb3ea to 6475cf1 Compare December 4, 2024 09:49
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 5f9927f to f0084d8 Compare December 4, 2024 09:50
dorimedini-starkware
dorimedini-starkware approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @TzahiTaub)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from f0084d8 to 2779f87 Compare December 4, 2024 10:40
dorimedini-starkware
dorimedini-starkware requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TzahiTaub)

This was referenced Dec 5, 2024
Merged
Merged
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch 2 times, most recently from 428e056 to b5d8874 Compare December 5, 2024 10:41
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 4215de2 to d076f8e Compare December 12, 2024 17:56
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from d076f8e to 9e86221 Compare December 15, 2024 07:40
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 9e86221 to 31b9b09 Compare December 15, 2024 09:13
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 31b9b09 to 1d07618 Compare December 15, 2024 11:43
@AvivYossef-starkware AvivYossef-starkware mentioned this pull request Dec 15, 2024
Merged
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 1d07618 to ea4ebab Compare December 15, 2024 12:33
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from ea4ebab to 2674f68 Compare December 15, 2024 14:05
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 2674f68 to 0646db2 Compare December 15, 2024 15:28
This was referenced Dec 15, 2024
Merged
Merged
Open
Open
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 0646db2 to 168ae5f Compare December 15, 2024 18:11
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/get_versioned_casm to graphite-base/2438 December 15, 2024 19:02
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 168ae5f to 49cc29a Compare December 15, 2024 19:03
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/2438 to main December 15, 2024 19:03
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/add_sierra_version_to_papyrus_cache branch from 49cc29a to 476a794 Compare December 15, 2024 19:03
@AvivYossef-starkware AvivYossef-starkware merged commit 50f3ce2 into main Dec 15, 2024
17 checks passed
@AvivYossef-starkware Graphite App
Copy link
Contributor Author

Merge activity

  • Dec 15, 2:33 PM EST: A user merged this pull request with Graphite.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yoni-Starkware Yoni-Starkware Yoni-Starkware approved these changes

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

@TzahiTaub TzahiTaub Awaiting requested review from TzahiTaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AvivYossef-starkware @reviewable-StarkWare @dorimedini-starkware @Yoni-Starkware