refactor(starknet_integration_tests): add sierra contract class to dummy state

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• feat(papyrus_storage): get versioned casm #2420 : 2 dependent PRs (#2421 , #2438 )
• refactor(starknet_integration_tests): add sierra contract class to dummy state #2467 👈 (View in Graphite)
• feat(blockifier): get sierra contract class from feature contract #2466
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.94%. Comparing base (e3165c4) to head (511eafb).
Report is 739 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   40.10%   48.94%   +8.84%     
==========================================
  Files          26      290     +264     
  Lines        1895    33112   +31217     
  Branches     1895    33112   +31217     
==========================================
+ Hits          760    16208   +15448     
- Misses       1100    15803   +14703     
- Partials       35     1101    +1066     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @Yoni-Starkware)

---

a discussion (no related file):
please add reviewer(s) from mempool team

---

crates/starknet_integration_tests/src/state_reader.rs line 171 at r1 (raw file):

        }
    }
    sierra_contract_classes

use filter_map

Suggestion:

    contract_classes_to_retrieve
        .iter()
        .filter_map(|contract| {
            if contract.cairo_version() == CairoVersion::Cairo1 {
                Some((contract.class_hash(), contract.sierra()))
            } else {
                None
            }
        })
        .collect()

[AvivYossef-starkware]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

a discussion (no related file):

Previously, dorimedini-starkware wrote…

please add reviewer(s) from mempool team

I spoke with Dan before opening the PR, and he said it wasn’t necessary.

---

crates/starknet_integration_tests/src/state_reader.rs line 171 at r1 (raw file):

Previously, dorimedini-starkware wrote…

use filter_map

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)

---

crates/starknet_integration_tests/src/state_reader.rs line 171 at r2 (raw file):

            } else {
                None
            }

sorry, missed this earlier.
please use match, we currently have another version variant

Suggestion:

            match contract.cairo_version() {
                CairoVersion::Cairo0 => None,
                CairoVersion::Cairo1 => Some((contract.class_hash(), contract.sierra())),
                #[cfg(feature = "cairo_native")]
                CairoVersion::Native => Some((contract.class_hash(), contract.sierra())),                
            }

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

[AvivYossef-starkware]

Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/starknet_integration_tests/src/state_reader.rs line 171 at r2 (raw file):

Previously, dorimedini-starkware wrote…

sorry, missed this earlier.
please use match, we currently have another version variant

Done.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-05T14:02:32Z
• Started at 2024-12-05T14:31:38Z
• Started at 2024-12-08T09:17:14Z
• Started at 2024-12-08T09:35:48Z
• Started at 2024-12-08T09:36:07Z
• Started at 2024-12-08T09:36:07Z
• Started at 2024-12-08T09:36:37Z
• Started at 2024-12-08T09:36:41Z

[dorimedini-starkware]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @Yoni-Starkware)

---

crates/blockifier/src/test_utils.rs line 103 at r5 (raw file):

    pub fn is_cairo0(&self) -> bool {
        matches!(self, Self::Cairo0)
    }

here, you do have the feature, so use full match

Suggestion:

    pub fn is_cairo0(&self) -> bool {
        match self {
            Self::Cairo0 => true,
            Self::Cairo1 => false,
            #[cfg(feature = "cairo_native")]
            Self::Native => false,
        }
    }

---

crates/starknet_integration_tests/src/state_reader.rs line 169 at r5 (raw file):

    contract_classes_to_retrieve
        .filter(|contract| !contract.cairo_version().is_cairo0())
        .map(|contract| (contract.class_hash(), contract.sierra()))

non-blocking, but filter+map should probably just be filter_map

Suggestion:

        .filter_map(|contract| if !contract.cairo_version().is_cairo0() {
            Some((contract.class_hash(), contract.sierra()))
        } else { None })

[AvivYossef-starkware]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/test_utils.rs line 103 at r5 (raw file):

Previously, dorimedini-starkware wrote…

here, you do have the feature, so use full match

Done.

---

crates/starknet_integration_tests/src/state_reader.rs line 169 at r5 (raw file):

Previously, dorimedini-starkware wrote…

non-blocking, but filter+map should probably just be filter_map

Don’t you think this makes things clearer? I believe that using filter_map is a good option when the closure in the map returns an Option, as it clearly indicates what is being filtered. However, that isn’t the case for us. The logic behind the filter and the logic of the map are unrelated.

[dorimedini-starkware]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

[AvivYossef-starkware]

Merge activity

• Dec 8, 6:07 AM EST: A user merged this pull request with Graphite.