refactor(blockifier): use get versioned contract class in py state reader #2614

AvivYossef-starkware · 2024-12-10T08:17:21Z

No description provided.

reviewable-StarkWare · 2024-12-10T08:17:29Z

This change is

AvivYossef-starkware · 2024-12-10T08:17:42Z

chore(blockifier): add erc20 sierra contract #2668 : 2 dependent PRs (#2641 , #2678 )
refactor(blockifier): use get versioned contract class in py state reader #2614 👈 (View in Graphite)
refactor(papyrus_rpc): get compiled class #2493
feat(papyrus_storage): add sierra version to papyrus cache #2438
feat(papyrus_storage): get versioned casm #2420 : 1 other dependent PR (#2421 )
refactor(starknet_integration_tests): add sierra contract class to dummy state #2467
feat(blockifier): get sierra contract class from feature contract #2466
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-12-10T08:17:50Z

Artifacts upload workflows:

codecov · 2024-12-10T08:47:41Z

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 9.59%. Comparing base (53e73f8) to head (715c824).

Files with missing lines	Patch %	Lines
...ve_blockifier/src/state_readers/py_state_reader.rs	0.00%	15 Missing ⚠️

Additional details and impacted files

@@                               Coverage Diff                                @@
##           aviv/refactor_papyrus_rpc_get_contract_class   #2614       +/-   ##
================================================================================
- Coverage                                         47.89%   9.59%   -38.31%     
================================================================================
  Files                                               187     139       -48     
  Lines                                             23007   18452     -4555     
  Branches                                          23007   18452     -4555     
================================================================================
- Hits                                              11020    1771     -9249     
- Misses                                            10886   16326     +5440     
+ Partials                                           1101     355      -746

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AvivYossef-starkware

Python

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @Yoni-Starkware)

AvivYossef-starkware

Block until python passes Hodor

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

dorimedini-starkware

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

…ader

AvivYossef-starkware · 2024-12-17T20:08:36Z

Merge activity

Dec 17, 3:08 PM EST: A user started a stack merge that includes this pull request via Graphite.
Dec 17, 3:08 PM EST: A user merged this pull request with Graphite.

AvivYossef-starkware mentioned this pull request Dec 10, 2024

refactor(papyrus_rpc): get compiled class #2493

Merged

AvivYossef-starkware marked this pull request as ready for review December 10, 2024 08:17

AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch from 0999dfe to 0637840 Compare December 10, 2024 08:24

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from e372b53 to 40aecd0 Compare December 10, 2024 08:24

AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch from 0637840 to 447a92d Compare December 10, 2024 08:27

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 40aecd0 to 792e0ff Compare December 10, 2024 08:28

AvivYossef-starkware force-pushed the aviv/get_versioned_casm branch from 447a92d to ceffe13 Compare December 10, 2024 10:56

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 792e0ff to dbd8356 Compare December 10, 2024 10:57

AvivYossef-starkware changed the base branch from aviv/get_versioned_casm to aviv/refactor_papyrus_rpc_get_contract_class December 10, 2024 10:57

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from 15f47f5 to 2ea9929 Compare December 10, 2024 10:58

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from dbd8356 to 66ca4ac Compare December 10, 2024 10:58

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from 2ea9929 to ea44d6f Compare December 10, 2024 14:43

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 66ca4ac to 294da4d Compare December 10, 2024 14:43

AvivYossef-starkware mentioned this pull request Dec 10, 2024

refactor(blockifier): state reader trait #2641

Closed

AvivYossef-starkware requested review from Yoni-Starkware and dorimedini-starkware December 10, 2024 15:14

AvivYossef-starkware commented Dec 10, 2024

View reviewed changes

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from ea44d6f to cc83787 Compare December 12, 2024 17:56

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 294da4d to f714969 Compare December 12, 2024 17:56

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from cc83787 to 53e73f8 Compare December 15, 2024 07:41

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from f714969 to 715c824 Compare December 15, 2024 07:41

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from 998c0ba to 348f11c Compare December 15, 2024 14:05

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 57b45d3 to 29d2e1e Compare December 15, 2024 14:05

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from 348f11c to 5a28773 Compare December 15, 2024 15:28

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 29d2e1e to 3a292c7 Compare December 15, 2024 15:28

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from 5a28773 to fd172ca Compare December 15, 2024 18:11

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 3a292c7 to 2605638 Compare December 15, 2024 18:11

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch from fd172ca to c1a5904 Compare December 15, 2024 19:03

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 2605638 to 56b7c70 Compare December 15, 2024 19:04

AvivYossef-starkware force-pushed the aviv/refactor_papyrus_rpc_get_contract_class branch 2 times, most recently from 7efc710 to 3fe6ead Compare December 15, 2024 19:34

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 56b7c70 to aab30c9 Compare December 15, 2024 19:34

AvivYossef-starkware changed the base branch from aviv/refactor_papyrus_rpc_get_contract_class to graphite-base/2614 December 15, 2024 20:06

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from aab30c9 to c832388 Compare December 15, 2024 20:07

AvivYossef-starkware force-pushed the graphite-base/2614 branch from 3fe6ead to d062b7a Compare December 15, 2024 20:07

AvivYossef-starkware changed the base branch from graphite-base/2614 to main December 15, 2024 20:07

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from c832388 to e66c37b Compare December 15, 2024 20:07

AvivYossef-starkware commented Dec 15, 2024

View reviewed changes

dorimedini-starkware approved these changes Dec 16, 2024

View reviewed changes

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from e66c37b to 8e31c3e Compare December 17, 2024 09:17

refactor(blockifier): use get versioned contract class in py state re…

742f02f

…ader

AvivYossef-starkware force-pushed the aviv/refactor_py_state_reader branch from 8e31c3e to 742f02f Compare December 17, 2024 12:09

AvivYossef-starkware merged commit eb9b1ab into main Dec 17, 2024
10 checks passed

This was referenced Dec 18, 2024

refactor(blockifier): min compiler version for sierra gas type #2752

Open

refactor(blockifier): use sierra version in native blockifier #2809

Open

github-actions bot locked and limited conversation to collaborators Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(blockifier): use get versioned contract class in py state reader #2614

refactor(blockifier): use get versioned contract class in py state reader #2614

AvivYossef-starkware commented Dec 10, 2024

reviewable-StarkWare commented Dec 10, 2024

AvivYossef-starkware commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

AvivYossef-starkware left a comment

AvivYossef-starkware left a comment

dorimedini-starkware left a comment

AvivYossef-starkware commented Dec 17, 2024 •

edited

Loading

refactor(blockifier): use get versioned contract class in py state reader #2614

refactor(blockifier): use get versioned contract class in py state reader #2614

Conversation

AvivYossef-starkware commented Dec 10, 2024

reviewable-StarkWare commented Dec 10, 2024

AvivYossef-starkware commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 10, 2024 • edited Loading

codecov bot commented Dec 10, 2024 • edited Loading

Codecov Report

AvivYossef-starkware left a comment

Choose a reason for hiding this comment

AvivYossef-starkware left a comment

Choose a reason for hiding this comment

dorimedini-starkware left a comment

Choose a reason for hiding this comment

AvivYossef-starkware commented Dec 17, 2024 • edited Loading

Merge activity

AvivYossef-starkware commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

AvivYossef-starkware commented Dec 17, 2024 •

edited

Loading