refactor(blockifier): use sierra version in native blockifier #2809
Conversation
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Need to add python PR
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)
a discussion (no related file):
blocking, pending python PR
crates/blockifier/src/execution/contract_class.rs line 311 at r1 (raw file):
pub fn try_from_json_string( (raw_contract_class, sierra_version): (&str, SierraVersion),
why tuple and not two params? non-blocking
Suggestion:
raw_contract_class: &str, sierra_version: SierraVersion
AvivYossef-starkware
force-pushed
the
aviv/use_sierra_version_in_native_blockifier
branch
from
18c18b1 to
1c1fd9d
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
blocking, pending python PR
crates/blockifier/src/execution/contract_class.rs line 311 at r1 (raw file):
Previously, dorimedini-starkware wrote…
why tuple and not two params? non-blocking
Its a good question
lol
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
AvivYossef-starkware
force-pushed
the
aviv/refactor_blockifier_contract_class
branch
from
a040553 to
87285bf
Compare
AvivYossef-starkware
force-pushed
the
aviv/use_sierra_version_in_native_blockifier
branch
from
1c1fd9d to
09c392b
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_blockifier_contract_class
branch
2 times, most recently
from
4022be4 to
0b19960
Compare
AvivYossef-starkware
force-pushed
the
aviv/use_sierra_version_in_native_blockifier
branch
from
09c392b to
2553415
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_blockifier_contract_class
branch
from
0b19960 to
5d8e938
Compare
AvivYossef-starkware
force-pushed
the
aviv/use_sierra_version_in_native_blockifier
branch
from
2553415 to
46b65f0
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_blockifier_contract_class
branch
from
5d8e938 to
e6dbb02
Compare
AvivYossef-starkware
force-pushed
the
aviv/use_sierra_version_in_native_blockifier
branch
from
46b65f0 to
facff36
Compare
AvivYossef-starkware
force-pushed
the
aviv/refactor_blockifier_contract_class
branch
2 times, most recently
from
3b35f20 to
f88449c
Compare
AvivYossef-starkware
force-pushed
the
aviv/use_sierra_version_in_native_blockifier
branch
from
facff36 to
850718f
Compare
No description provided.