Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for serde wrapper #2463

Closed
wants to merge 1 commit into from
Closed

test: add tests for serde wrapper #2463

wants to merge 1 commit into from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Dec 4, 2024 •
edited
Loading

This was referenced Dec 4, 2024
Closed
Merged
Closed
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Artifacts upload workflows:

@nadin-Starkware nadin-Starkware force-pushed the spr/main/d92345f3 branch 2 times, most recently from 04e7764 to ef08e76 Compare December 8, 2024 06:58
@nadin-Starkware nadin-Starkware mentioned this pull request Dec 8, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.115 ms 34.146 ms 34.182 ms]
change: [-3.0893% -2.1400% -1.3026%] (p = 0.00 < 0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe

@nadin-Starkware nadin-Starkware force-pushed the spr/main/d92345f3 branch 3 times, most recently from efd6310 to 49c5b35 Compare December 8, 2024 11:16
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (9350235) to head (7cbea36).

Additional details and impacted files 
@@                  Coverage Diff                   @@
##           spr/main/7926e8e6    #2463       +/-   ##
======================================================
+ Coverage              55.55%   77.49%   +21.94%     
======================================================
  Files                      9      386      +377     
  Lines                    315    41370    +41055     
  Branches                 315    41370    +41055     
======================================================
+ Hits                     175    32060    +31885     
- Misses                   130     7029     +6899     
- Partials                  10     2281     +2271

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Itay-Tsabary-Starkware
Itay-Tsabary-Starkware approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware
Copy link
Collaborator Author

✓ Commit merged in pull request #2506

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware Itay-Tsabary-Starkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadin-Starkware @reviewable-StarkWare @Itay-Tsabary-Starkware