Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config functions for remote flow test #2506

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Dec 8, 2024

commit-id:e9855990


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@nadin-Starkware nadin-Starkware force-pushed the spr/main/e9855990 branch 2 times, most recently from 80d4b19 to c3f1db6 Compare December 8, 2024 09:25
@nadin-Starkware nadin-Starkware force-pushed the spr/main/e9855990 branch 3 times, most recently from 1a0a65d to 183c942 Compare December 8, 2024 11:56
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 10.76923% with 58 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (e3165c4) to head (80af8bd).
Report is 749 commits behind head on main.

Files with missing lines Patch % Lines
...tes/starknet_integration_tests/src/config_utils.rs 0.00% 58 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2506       +/-   ##
===========================================
+ Coverage   40.10%   77.51%   +37.40%     
===========================================
  Files          26      386      +360     
  Lines        1895    41428    +39533     
  Branches     1895    41428    +39533     
===========================================
+ Hits          760    32113    +31353     
- Misses       1100     7035     +5935     
- Partials       35     2280     +2245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_integration_tests/src/config_utils.rs line 123 at r1 (raw file):

        remote_server_config: Some(RemoteServerConfig { socket }),
    }
}

Please add a todo to change these 3 generator functions to be "static" functions of ComponentExecutionConfig, a la new.

Code quote:

pub fn get_disabled_component_config() -> ComponentExecutionConfig {
    ComponentExecutionConfig {
        execution_mode: ComponentExecutionMode::Disabled,
        local_server_config: None,
        remote_client_config: None,
        remote_server_config: None,
    }
}

pub fn get_remote_component_config(socket: SocketAddr) -> ComponentExecutionConfig {
    ComponentExecutionConfig {
        execution_mode: ComponentExecutionMode::Remote,
        local_server_config: None,
        remote_client_config: Some(RemoteClientConfig { socket, ..RemoteClientConfig::default() }),
        remote_server_config: None,
    }
}

pub fn get_local_with_remote_enabled_component_config(
    socket: SocketAddr,
) -> ComponentExecutionConfig {
    ComponentExecutionConfig {
        execution_mode: ComponentExecutionMode::LocalExecutionWithRemoteEnabled,
        local_server_config: Some(LocalServerConfig::default()),
        remote_client_config: None,
        remote_server_config: Some(RemoteServerConfig { socket }),
    }
}

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_integration_tests/src/config_utils.rs line 123 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add a todo to change these 3 generator functions to be "static" functions of ComponentExecutionConfig, a la new.

Done.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the base branch from spr/main/d92345f3 to main December 8, 2024 15:08
@nadin-Starkware nadin-Starkware merged commit 726574c into main Dec 8, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants