-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config functions for remote flow test #2506
Conversation
ef08e76
to
dcbab84
Compare
80d4b19
to
c3f1db6
Compare
b748dfb
to
efd6310
Compare
1a0a65d
to
183c942
Compare
49c5b35
to
3aa7275
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2506 +/- ##
===========================================
+ Coverage 40.10% 77.51% +37.40%
===========================================
Files 26 386 +360
Lines 1895 41428 +39533
Branches 1895 41428 +39533
===========================================
+ Hits 760 32113 +31353
- Misses 1100 7035 +5935
- Partials 35 2280 +2245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_integration_tests/src/config_utils.rs
line 123 at r1 (raw file):
remote_server_config: Some(RemoteServerConfig { socket }), } }
Please add a todo to change these 3 generator functions to be "static" functions of ComponentExecutionConfig
, a la new
.
Code quote:
pub fn get_disabled_component_config() -> ComponentExecutionConfig {
ComponentExecutionConfig {
execution_mode: ComponentExecutionMode::Disabled,
local_server_config: None,
remote_client_config: None,
remote_server_config: None,
}
}
pub fn get_remote_component_config(socket: SocketAddr) -> ComponentExecutionConfig {
ComponentExecutionConfig {
execution_mode: ComponentExecutionMode::Remote,
local_server_config: None,
remote_client_config: Some(RemoteClientConfig { socket, ..RemoteClientConfig::default() }),
remote_server_config: None,
}
}
pub fn get_local_with_remote_enabled_component_config(
socket: SocketAddr,
) -> ComponentExecutionConfig {
ComponentExecutionConfig {
execution_mode: ComponentExecutionMode::LocalExecutionWithRemoteEnabled,
local_server_config: Some(LocalServerConfig::default()),
remote_client_config: None,
remote_server_config: Some(RemoteServerConfig { socket }),
}
}
commit-id:aa03526b
commit-id:7926e8e6
commit-id:d92345f3
commit-id:e9855990
183c942
to
80af8bd
Compare
3aa7275
to
7cbea36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/config_utils.rs
line 123 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please add a todo to change these 3 generator functions to be "static" functions of
ComponentExecutionConfig
, a lanew
.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
commit-id:e9855990
Stack: