refactor(starknet_batcher): add getters to the proposal manger

[dafnamatsry]

No description provided.

[reviewable-StarkWare]

This change is 

[dafnamatsry]

• refactor(starknet_batcher): add tests and refactor batcher_test #2640
• refactor(starknet_batcher): delete the proposal manager #2618
• refactor(starknet_batcher): move around some types and utils to a common utils file #2622
• refactor(starknet_batcher): validate flow refactor #2441
• refactor(starknet_batcher): rename GetProposalResultError and remove the ProposalNotFound variant #2483
• refactor(starknet_batcher): add getters to the proposal manger #2480 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 6.22%. Comparing base (e3165c4) to head (b241765).
Report is 756 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_batcher/src/proposal_manager.rs	53.84%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #2480       +/-   ##
==========================================
- Coverage   40.10%   6.22%   -33.88%     
==========================================
  Files          26     141      +115     
  Lines        1895   17113    +15218     
  Branches     1895   17113    +15218     
==========================================
+ Hits          760    1066      +306     
- Misses       1100   15989    +14889     
- Partials       35      58       +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yael-Starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dafnamatsry)

---

crates/starknet_batcher/src/proposal_manager.rs line 93 at r1 (raw file):

    pub abort_signal_sender: tokio::sync::oneshot::Sender<()>,
    pub join_handle: tokio::task::JoinHandle<()>,
}

why is the pub required?

Code quote:

pub struct ProposalTask {
    pub abort_signal_sender: tokio::sync::oneshot::Sender<()>,
    pub join_handle: tokio::task::JoinHandle<()>,
}

[dafnamatsry]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @Yael-Starkware)

---

crates/starknet_batcher/src/proposal_manager.rs line 93 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

why is the pub required?

Removed. (left by mistake)

[Yael-Starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[alonh5]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

Merge activity

• Dec 9, 6:47 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 9, 6:47 AM EST: A user merged this pull request with Graphite.