Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(starknet_batcher): add tests and refactor batcher_test #2640

Open
wants to merge 1 commit into
base: 12-05-refactor_starknet_batcher_delete_the_proposal_manager
Choose a base branch
from
Open

refactor(starknet_batcher): add tests and refactor batcher_test #2640

wants to merge 1 commit into from
+150 −107

Conversation

dafnamatsry
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Dec 10, 2024
Open
Merged
Merged
Merged
@dafnamatsry Graphite App
Copy link
Collaborator Author

dafnamatsry commented Dec 10, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dafnamatsry dafnamatsry mentioned this pull request Dec 10, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.43%. Comparing base (cdaa5ee) to head (99186c5).

Files with missing lines Patch % Lines
crates/starknet_batcher_types/src/batcher_types.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@                                      Coverage Diff                                       @@
##           12-05-refactor_starknet_batcher_delete_the_proposal_manager   #2640      +/-   ##
==============================================================================================
+ Coverage                                                         6.31%   6.43%   +0.11%     
==============================================================================================
  Files                                                              145     145              
  Lines                                                            17335   17336       +1     
  Branches                                                         17335   17336       +1     
==============================================================================================
+ Hits                                                              1095    1115      +20     
+ Misses                                                           16166   16150      -16     
+ Partials                                                            74      71       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch 2 times, most recently from c948824 to 2556745 Compare December 10, 2024 14:56
@dafnamatsry dafnamatsry marked this pull request as ready for review December 10, 2024 14:59
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from cfc0dcc to 8b33c06 Compare December 12, 2024 09:17
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from 2556745 to eb32843 Compare December 12, 2024 09:17
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 8b33c06 to 9aaf571 Compare December 12, 2024 10:20
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from eb32843 to 7bbc6e6 Compare December 12, 2024 10:20
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 9aaf571 to 1582e58 Compare December 12, 2024 10:29
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from 7bbc6e6 to ef53aaa Compare December 12, 2024 10:29
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 1582e58 to b315f6c Compare December 12, 2024 10:49
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch 2 times, most recently from fc9981e to 7e49dc2 Compare December 12, 2024 10:55
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from b315f6c to cdaa5ee Compare December 15, 2024 07:23
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from 7e49dc2 to 99186c5 Compare December 15, 2024 07:24
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from cdaa5ee to 89fb62f Compare December 15, 2024 12:12
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from 99186c5 to 991a42f Compare December 15, 2024 12:12
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 89fb62f to 7b9ca0b Compare December 15, 2024 12:21
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from 991a42f to f7f075b Compare December 15, 2024 12:21
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 7b9ca0b to 35adc06 Compare December 16, 2024 07:17
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from f7f075b to d4cdaf2 Compare December 16, 2024 07:17
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 35adc06 to 8c61b02 Compare December 16, 2024 09:03
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from d4cdaf2 to e6e9648 Compare December 16, 2024 09:03
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch 2 times, most recently from 72ce408 to e1fdcc8 Compare December 16, 2024 10:56
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from e6e9648 to e57284d Compare December 16, 2024 10:56
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from e1fdcc8 to 73d8a51 Compare December 16, 2024 13:01
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from e57284d to dca26ce Compare December 16, 2024 13:01
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from 73d8a51 to f8ffd4c Compare December 17, 2024 07:30
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch 3 times, most recently from 3ee7d5a to e8de1e3 Compare December 17, 2024 07:52
@dafnamatsry dafnamatsry force-pushed the 12-05-refactor_starknet_batcher_delete_the_proposal_manager branch from f8ffd4c to acc4aba Compare December 18, 2024 08:15
@dafnamatsry dafnamatsry force-pushed the 12-10-refactor_starknet_batcher_add_tests_and_refactor_batcher_test branch from e8de1e3 to 7bbd1f4 Compare December 18, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonh5 alonh5 Awaiting requested review from alonh5

@Yael-Starkware Yael-Starkware Awaiting requested review from Yael-Starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafnamatsry @reviewable-StarkWare