Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_integration_tests): moving all end_to_end_integration test functions to a module #2597

Closed

Conversation

lev-starkware
Copy link
Contributor

@lev-starkware lev-starkware commented Dec 9, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 35.00%. Comparing base (e3165c4) to head (26d77c7).
Report is 812 commits behind head on main.

Files with missing lines Patch % Lines
...et_integration_tests/src/end_to_end_integration.rs 0.00% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
- Coverage   40.10%   35.00%   -5.10%     
==========================================
  Files          26      277     +251     
  Lines        1895    32227   +30332     
  Branches     1895    32227   +30332     
==========================================
+ Hits          760    11282   +10522     
- Misses       1100    19939   +18839     
- Partials       35     1006     +971     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @lev-starkware)


crates/starknet_integration_tests/src/end_to_end_integration.rs line 17 at r1 (raw file):

/// Reads the latest block number from the storage.
pub fn get_latest_block_number(storage_reader: &StorageReader) -> BlockNumber {

Needed?

Code quote:

pub

crates/starknet_integration_tests/src/end_to_end_integration.rs line 26 at r1 (raw file):

/// Reads an account nonce after a block number from storage.
pub fn get_account_nonce(

Needed?

Code quote:

pub

crates/starknet_integration_tests/src/end_to_end_integration.rs line 40 at r1 (raw file):

/// Sample a storage until sufficiently many blocks have been stored. Returns an error if after
/// the given number of attempts the target block number has not been reached.
pub async fn await_block(

Needed?

Code quote:

pub

Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)


crates/starknet_integration_tests/src/end_to_end_integration.rs line 17 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Needed?

Done.


crates/starknet_integration_tests/src/end_to_end_integration.rs line 26 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Needed?

Done.


crates/starknet_integration_tests/src/end_to_end_integration.rs line 40 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Needed?

Done.

@lev-starkware lev-starkware force-pushed the pr/lev-starkware/lev/e2e_integration/b8a2fdfb branch from c6ead48 to 9ea8d82 Compare December 10, 2024 14:43
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

@lev-starkware lev-starkware force-pushed the pr/lev-starkware/lev/e2e_integration/b8a2fdfb branch from 9ea8d82 to 1e0c53d Compare December 10, 2024 15:09
Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

…on test functions to a module

commit-id:b8a2fdfb
@lev-starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2598

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants