-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(starknet_integration_tests): moving all end_to_end_integration test functions to a module #2597
Conversation
483f532
to
c6ead48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
==========================================
- Coverage 40.10% 35.00% -5.10%
==========================================
Files 26 277 +251
Lines 1895 32227 +30332
Branches 1895 32227 +30332
==========================================
+ Hits 760 11282 +10522
- Misses 1100 19939 +18839
- Partials 35 1006 +971 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @lev-starkware)
crates/starknet_integration_tests/src/end_to_end_integration.rs
line 17 at r1 (raw file):
/// Reads the latest block number from the storage. pub fn get_latest_block_number(storage_reader: &StorageReader) -> BlockNumber {
Needed?
Code quote:
pub
crates/starknet_integration_tests/src/end_to_end_integration.rs
line 26 at r1 (raw file):
/// Reads an account nonce after a block number from storage. pub fn get_account_nonce(
Needed?
Code quote:
pub
crates/starknet_integration_tests/src/end_to_end_integration.rs
line 40 at r1 (raw file):
/// Sample a storage until sufficiently many blocks have been stored. Returns an error if after /// the given number of attempts the target block number has not been reached. pub async fn await_block(
Needed?
Code quote:
pub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/end_to_end_integration.rs
line 17 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Needed?
Done.
crates/starknet_integration_tests/src/end_to_end_integration.rs
line 26 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Needed?
Done.
crates/starknet_integration_tests/src/end_to_end_integration.rs
line 40 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Needed?
Done.
c6ead48
to
9ea8d82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
9ea8d82
to
1e0c53d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
…on test functions to a module commit-id:b8a2fdfb
1e0c53d
to
26d77c7
Compare
✓ Commit merged in pull request #2598 |
Stack: