-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_integration_tests): running end to end integration tes… #2642
chore(starknet_integration_tests): running end to end integration tes… #2642
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
==========================================
- Coverage 40.10% 34.76% -5.35%
==========================================
Files 26 289 +263
Lines 1895 33186 +31291
Branches 1895 33186 +31291
==========================================
+ Hits 760 11536 +10776
- Misses 1100 20642 +19542
- Partials 35 1008 +973 ☔ View full report in Codecov by Sentry. |
7f9a7e0
to
7a421f7
Compare
7a421f7
to
e3ef8da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)
.github/workflows/sequencer_integration_tests.yml
line 13 at r1 (raw file):
env: SEQUENCER_INTEGRATION_TESTS: 1
Please also delete the following function:
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_integration_tests/src/utils.rs#L253-L255
Code quote:
SEQUENCER_INTEGRATION_TESTS: 1
…t as binary commit-id:b11c15b5
e3ef8da
to
ca1d6a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
.github/workflows/sequencer_integration_tests.yml
line 13 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please also delete the following function:
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_integration_tests/src/utils.rs#L253-L255
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
…t as binary
commit-id:b11c15b5
Stack: