Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_gateway): use const for json rpc version #2609

Closed
wants to merge 1 commit into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 10, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/640fe6f5 to main December 10, 2024 07:53
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to spr/main/640fe6f5 December 10, 2024 07:53
Copy link

github-actions bot commented Dec 10, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 26.52%. Comparing base (7878126) to head (e1fff9f).

Files with missing lines Patch % Lines
crates/starknet_gateway/src/config.rs 37.50% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           spr/main/640fe6f5    #2609       +/-   ##
======================================================
+ Coverage                   0   26.52%   +26.52%     
======================================================
  Files                      0      125      +125     
  Lines                      0    14991    +14991     
  Branches                   0    14991    +14991     
======================================================
+ Hits                       0     3977     +3977     
- Misses                     0    10747    +10747     
- Partials                   0      267      +267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2611

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants