Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockifier_reexecution): remove const for json rpc version #2610

Closed
wants to merge 1 commit into from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Dec 10, 2024

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (spr/main/69ba79bd@e1fff9f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...s/blockifier_reexecution/src/state_reader/utils.rs 0.00% 2 Missing ⚠️
crates/blockifier_reexecution/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             spr/main/69ba79bd    #2610   +/-   ##
====================================================
  Coverage                     ?   49.76%           
====================================================
  Files                        ?      175           
  Lines                        ?    20454           
  Branches                     ?    20454           
====================================================
  Hits                         ?    10179           
  Misses                       ?     9788           
  Partials                     ?      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from spr/main/69ba79bd to main December 10, 2024 07:53
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from main to spr/main/69ba79bd December 10, 2024 07:53
Copy link

github-actions bot commented Dec 10, 2024

Artifacts upload workflows:

Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.070 ms 34.097 ms 34.128 ms]
change: [-4.5868% -3.0920% -1.8445%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
4 (4.00%) high mild
4 (4.00%) high severe

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware
Copy link
Contributor Author

✓ Commit merged in pull request #2611

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants