Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_batcher): validate height matches storage on add sync block #2733

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Dec 17, 2024

@ArniStarkware ArniStarkware requested a review from alonh5 December 17, 2024 14:39
@ArniStarkware ArniStarkware marked this pull request as ready for review December 17, 2024 14:39
@ArniStarkware ArniStarkware force-pushed the arni/batcher/start_height/validate_height_matches_storage branch from 3102d4b to 2c2222f Compare December 18, 2024 07:52
@ArniStarkware ArniStarkware force-pushed the arni/batcher/add_sync_state/validate_height_matches_storage branch from 81a017e to e695568 Compare December 18, 2024 07:52
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


a discussion (no related file):
Let's keep it simple, we only want to panic if the height it wrong.

@ArniStarkware ArniStarkware force-pushed the arni/batcher/add_sync_state/validate_height_matches_storage branch from e695568 to 825dff3 Compare December 18, 2024 11:21
@ArniStarkware ArniStarkware changed the base branch from arni/batcher/start_height/validate_height_matches_storage to main December 18, 2024 11:21
@ArniStarkware ArniStarkware force-pushed the arni/batcher/add_sync_state/validate_height_matches_storage branch from 825dff3 to ef4ff01 Compare December 18, 2024 11:35
@ArniStarkware ArniStarkware requested a review from alonh5 December 18, 2024 11:35
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5)


a discussion (no related file):

Previously, alonh5 (Alon Haramati) wrote…

Let's keep it simple, we only want to panic if the height it wrong.

Done.

@ArniStarkware
Copy link
Contributor Author

Replaced with the simpler: #2759

@ArniStarkware ArniStarkware deleted the arni/batcher/add_sync_state/validate_height_matches_storage branch December 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants