feat(starknet_batcher): validate height matches storage on decision reached

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(starknet_batcher): validate height matches storage on decision reached #2750 👈 (View in Graphite)
• feat(starknet_batcher): validate height matches storage on add sync block #2733
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

crates/starknet_batcher/src/batcher.rs line 386 at r1 (raw file):

        // TODO(Arni): Get the height from the proposal output or from the proposal id. Pass it to
        // commit proposal and block. set the variable as non-optional.

delete this.

Code quote:

        // TODO(Arni): Get the height from the proposal output or from the proposal id. Pass it to
        // commit proposal and block. set the variable as non-optional.

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 297 at r1 (raw file):

        // TODO(matan): Broadcast the decision to the network.

        let height = BlockNumber(height);

Suggestion:

        let height = BlockNumber(precommits[0].height);
        info!("Finished consensus for height: {height}. Agreed on block: {:#064x}", block.0);

        // TODO(matan): Broadcast the decision to the network.

[ArniStarkware]

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_batcher/src/batcher.rs line 386 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

delete this.

Done.

---

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 297 at r1 (raw file):

        // TODO(matan): Broadcast the decision to the network.

        let height = BlockNumber(height);

Done.

[ArniStarkware]

Can be closed for now. Now that we get the active height from self.