chore: refactor deploy account as wrapper #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(format): run format fix on all repo
chore: sync repos
chore: add committer
Signed-off-by: Dori Medini <dori@starkware.co>
* feature(ci): Identify which package need to be built according to file changed --------- Signed-off-by: Dori Medini <dori@starkware.co> Co-authored-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
* chore: fix ci to always compare changes against the target branch
* chore: copy all crates * chore: switch to local dependencies * chore: delete old papyrus_test_utils crate * chore: rename crate test_utils -> papyrus_test_utils * chore: fix RPCTransactio name in the mempool * chore: fix mockito deps in papyrus and gateway * chore: update cairo-* deps version * chore: update config and presets for mempool and papyrus * chore: rename default_config.json -> papyrus_default_config.json * chore: rustfmt * chore: reorg folders * chore: reorg folders * chore: fix unused deps * chore: update papyrus Dockerfile * chore: update scripts folder * chore: copy build_native_blockifier.sh * chore: copy BUILD and WORKSPACE files (from blockifier and committer) * chore: update papyrus non crates folders and files * chore: copy blockifier docs * chore: copy committer taplo.toml * chore: fix config tests * chore: copy blockifier docker file * fix: papyrus integration test runs only Papyrus related tests * chore: rename conflicting dump_config.rs files * chore: fix cargo doc errors * chore: fix CI * chore: small optimizations for the papyrus CI * chore: copy README files * chore: meld common repo files --------- Co-authored-by: alon.dotan <alon.dotan@starkware.co> Co-authored-by: Dan Brownstein <dan@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Co-Authored-By: alon.dotan <alon.dotan@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
Signed-off-by: Dori Medini <dori@starkware.co>
…in-v0.13.2-into-main
…ange needed to pass the CI.
…to-main Dori/Merge main-v0.13.2 into main
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
9 tasks
ArniStarkware
force-pushed
the
arni/refactor/account_tx_wrapper/deploy_account
branch
from
cfa14c3 to
7431abd
Compare
9 tasks
ArniStarkware
commented
Jul 24, 2024
There was a problem hiding this comment.
Collides with #40. To be determined which one is preferable.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @MohammadNassar1)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
For internal deploy account transaction, the data is inseparable from the implementation.
The data of
IntrnalDeployAccountTransactionand ofDeployAccountTransaction(on the blockifier) is duplicated.What is the new behavior?
DeployAccountTransactionas a wrapper ofIntrnalDeployAccountTransactionwhile keeping the implementation.Does this introduce a breaking change?
Other information
This change is