Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use deploy account transaction extension trait #40

Closed

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 24, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is code duplication between SNAPI InternalDeployAccountTransaction and blockifier DeployAccountTransaction.
The struct DeployAccountTransaction has additional functionality.

What is the new behavior?

  • The blockifier struct DeployAccountTransaction is replaced with a type by the same name, which points to the SNAPI struct.
  • The implementation is layered under an extension trait.

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Sorry, something went wrong.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review July 24, 2024 07:02
@ArniStarkware ArniStarkware force-pushed the arni/refactor/account_tx_impl/deploy_account branch from 3a76336 to 5f2855e Compare July 24, 2024 07:07
@ArniStarkware
Copy link
Contributor Author

Collides with #38. To be determined which one is preferable.

@ArniStarkware
Copy link
Contributor Author

Replaced with #38.

@ArniStarkware ArniStarkware deleted the arni/refactor/account_tx_impl/deploy_account branch July 24, 2024 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant