chore: streamline tx_hash getter method #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
This was referenced Aug 12, 2024
ArniStarkware
force-pushed
the
arni/small_refactor_account_tx/invoke
branch
from
18ae2fe to
ff470bf
Compare
ArniStarkware
force-pushed
the
arni/small_refactor_account_tx/tx_hash_method
branch
from
959f0e7 to
3cdd457
Compare
This was referenced Aug 12, 2024
MohammadNassar1
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
Merge activity
|
ArniStarkware
changed the base branch from
arni/small_refactor_account_tx/invoke
to
graphite-base/399
ArniStarkware
force-pushed
the
arni/small_refactor_account_tx/tx_hash_method
branch
from
3cdd457 to
4f1ee55
Compare
ArniStarkware
force-pushed
the
arni/small_refactor_account_tx/tx_hash_method
branch
from
4f1ee55 to
7d7fd90
Compare
MohammadNassar1
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
ArniStarkware
deleted the
arni/small_refactor_account_tx/tx_hash_method
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is