-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make tx_hash member private #410
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
a discussion (no related file):
Why does tx_hash need to be private while others aren't?
421e398
to
10278da
Compare
3cdd457
to
7d7fd90
Compare
Benchmark movements: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## graphite-base/410 #410 +/- ##
====================================================
Coverage ? 76.61%
====================================================
Files ? 344
Lines ? 36193
Branches ? 36193
====================================================
Hits ? 27731
Misses ? 6161
Partials ? 2301 ☔ View full report in Codecov by Sentry. |
7d7fd90
to
7082e88
Compare
10278da
to
9cbd947
Compare
There is no need for this PR. |
This change is