Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make tx_hash member private #410

Closed

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 12, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 12, 2024

Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

a discussion (no related file):
Why does tx_hash need to be private while others aren't?


@ArniStarkware ArniStarkware changed the base branch from arni/small_refactor_account_tx/tx_hash_method to graphite-base/410 August 14, 2024 04:48
@ArniStarkware ArniStarkware force-pushed the arni/small_refactor_account_tx/private_tx_hash branch from 421e398 to 10278da Compare August 14, 2024 06:45
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [65.703 ms 66.206 ms 66.964 ms]
change: [-8.0369% -4.7223% -1.8845%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (graphite-base/410@7d7fd90). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             graphite-base/410     #410   +/-   ##
====================================================
  Coverage                     ?   76.61%           
====================================================
  Files                        ?      344           
  Lines                        ?    36193           
  Branches                     ?    36193           
====================================================
  Hits                         ?    27731           
  Misses                       ?     6161           
  Partials                     ?     2301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/small_refactor_account_tx/private_tx_hash branch from 10278da to 9cbd947 Compare August 14, 2024 07:11
@ArniStarkware ArniStarkware changed the base branch from graphite-base/410 to main August 14, 2024 07:12
@ArniStarkware
Copy link
Contributor Author

There is no need for this PR.

@ArniStarkware ArniStarkware deleted the arni/small_refactor_account_tx/private_tx_hash branch August 14, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants