-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move sn_api_to_cairo_vm_program into snapi #433
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
Benchmark movements: |
Benchmark movements: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arni/contract_class_refactor/remove_redundent_try_from_methods #433 +/- ##
===============================================================================================
Coverage 76.74% 76.75%
===============================================================================================
Files 348 348
Lines 36313 36313
Branches 36313 36313
===============================================================================================
+ Hits 27869 27871 +2
+ Misses 6125 6124 -1
+ Partials 2319 2318 -1 ☔ View full report in Codecov by Sentry. |
6df2124
to
376a76d
Compare
c892b2b
to
6a04971
Compare
376a76d
to
6120a00
Compare
6a04971
to
0d41708
Compare
Benchmark movements: |
Move to common. Code quote: // TODO(Elin,01/05/2023): aim to use LC's implementation once it's in a separate crate.
pub fn sn_api_to_cairo_vm_program(program: Program) -> Result<CairoVmProgram, ProgramError> { |
6120a00
to
85e18ed
Compare
0d41708
to
537d64b
Compare
Benchmark movements: |
We continue with a different path. We will not create the |
This change is