Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move sn_api_to_cairo_vm_program into snapi #433

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 13, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [48.165 ms 48.231 ms 48.307 ms]
change: [+2.5759% +2.8245% +3.0738%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
2 (2.00%) high mild
5 (5.00%) high severe

Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [48.083 ms 48.131 ms 48.185 ms]
change: [+2.7155% +2.9602% +3.1672%] (p = 0.00 < 0.05)
Performance has regressed.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severe

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.75%. Comparing base (45bd013) to head (537d64b).

Files Patch % Lines
...ates/starknet_api/src/deprecated_contract_class.rs 69.23% 1 Missing and 7 partials ⚠️
Additional details and impacted files
@@                                       Coverage Diff                                       @@
##           arni/contract_class_refactor/remove_redundent_try_from_methods     #433   +/-   ##
===============================================================================================
  Coverage                                                           76.74%   76.75%           
===============================================================================================
  Files                                                                 348      348           
  Lines                                                               36313    36313           
  Branches                                                            36313    36313           
===============================================================================================
+ Hits                                                                27869    27871    +2     
+ Misses                                                               6125     6124    -1     
+ Partials                                                             2319     2318    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/order_pub_funcs branch from 6df2124 to 376a76d Compare August 14, 2024 09:00
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi branch from c892b2b to 6a04971 Compare August 14, 2024 09:00
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/order_pub_funcs branch from 376a76d to 6120a00 Compare August 14, 2024 11:03
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi branch from 6a04971 to 0d41708 Compare August 14, 2024 11:03
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [64.622 ms 64.690 ms 64.769 ms]
change: [-9.0321% -5.7255% -2.9757%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe

@ArniStarkware
Copy link
Contributor Author

crates/starknet_api/src/deprecated_contract_class.rs line 153 at r2 (raw file):

// TODO(Elin,01/05/2023): aim to use LC's implementation once it's in a separate crate.
pub fn sn_api_to_cairo_vm_program(program: Program) -> Result<CairoVmProgram, ProgramError> {

Move to common.

Code quote:

// TODO(Elin,01/05/2023): aim to use LC's implementation once it's in a separate crate.
pub fn sn_api_to_cairo_vm_program(program: Program) -> Result<CairoVmProgram, ProgramError> {

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/order_pub_funcs branch from 6120a00 to 85e18ed Compare August 18, 2024 06:51
@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi branch from 0d41708 to 537d64b Compare August 18, 2024 06:51
@ArniStarkware ArniStarkware changed the base branch from arni/contract_class_refactor/order_pub_funcs to arni/contract_class_refactor/remove_redundent_try_from_methods August 18, 2024 06:51
Copy link

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [47.900 ms 47.947 ms 48.000 ms]
change: [+1.1561% +1.9301% +2.4682%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe

@ArniStarkware
Copy link
Contributor Author

We continue with a different path. We will not create the common crate for this project.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@ArniStarkware ArniStarkware deleted the arni/contract_class_refactor/move_sn_api_to_cairo_vm_program_into_snapi branch October 26, 2024 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant