Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move contract class struct to snapi #435

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 13, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 92.90780% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (arni/contract_class_refactor/remove_redundent_try_from_methods@2591105). Learn more about missing BASE report.

Files Patch % Lines
crates/starknet_api/src/contract_class.rs 92.92% 1 Missing and 7 partials ⚠️
crates/blockifier/src/execution/contract_class.rs 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                        @@
##             arni/contract_class_refactor/remove_redundent_try_from_methods     #435   +/-   ##
=================================================================================================
  Coverage                                                                  ?   76.17%           
=================================================================================================
  Files                                                                     ?      331           
  Lines                                                                     ?    35272           
  Branches                                                                  ?    35272           
=================================================================================================
  Hits                                                                      ?    26867           
  Misses                                                                    ?     6110           
  Partials                                                                  ?     2295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/contract_class_refactor/remove_redundent_try_from_methods branch 2 times, most recently from 07ccbdb to 0aa4641 Compare August 14, 2024 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@ArniStarkware ArniStarkware deleted the arni/move_contract_class_to_starknet_api/try_2 branch October 26, 2024 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant