-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fee): transaction info creator may fail #506
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nimrod-starkware and the rest of your teammates on Graphite |
6c04dce
to
643aa9e
Compare
d89e3fd
to
4668bc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)
crates/blockifier/src/context.rs
line 71 at r1 (raw file):
TransactionContext { block_context: self.clone(), tx_info: tx_info_creator.create_tx_info().expect("todo"),
will be handled in an upper branch on the stack
Code quote:
.expect("todo"),
643aa9e
to
dfa48cb
Compare
4668bc1
to
a9bca83
Compare
dfa48cb
to
284b275
Compare
a9bca83
to
0edc05f
Compare
284b275
to
5c1091f
Compare
0edc05f
to
162f6e2
Compare
5c1091f
to
656eb85
Compare
162f6e2
to
61d58fd
Compare
656eb85
to
69c29c6
Compare
61d58fd
to
3fafce9
Compare
69c29c6
to
c8be06a
Compare
3fafce9
to
b6769b7
Compare
c8be06a
to
fa091b8
Compare
b6769b7
to
dc03a97
Compare
4335170
to
c56a171
Compare
bdd4705
to
0d6e837
Compare
c56a171
to
ab8f232
Compare
0d6e837
to
f728fc1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 76.62% 76.58% -0.04%
==========================================
Files 351 351
Lines 37102 37100 -2
Branches 37102 37100 -2
==========================================
- Hits 28429 28414 -15
- Misses 6372 6380 +8
- Partials 2301 2306 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
ab8f232
to
00cdc07
Compare
f728fc1
to
669b111
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
00cdc07
to
582f4b3
Compare
669b111
to
8b53820
Compare
582f4b3
to
cf259fe
Compare
8b53820
to
18bf0a3
Compare
cf259fe
to
50712c6
Compare
18bf0a3
to
a658b50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
Merge activity
|
a658b50
to
2e1ece9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
This change is