Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address types when necessary #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maciejka
Copy link

@maciejka maciejka commented Jul 3, 2024

This change is Reviewable

@ArielElp ArielElp self-requested a review July 4, 2024 09:17
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @maciejka)

@maciejka maciejka force-pushed the mk/fix-addresses branch from 01d4f90 to 4f17014 Compare July 8, 2024 20:27
@maciejka maciejka requested a review from ArielElp July 8, 2024 20:27
Copy link
Author

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged. @ArielElp

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @ArielElp)

@Safay99
Copy link

Safay99 commented Oct 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants