Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xdr, env, sdk, strkey deps to compat with 22.0.0-rc.1 stream #1646

Merged
merged 16 commits into from
Oct 9, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 2, 2024

What

Update xdr, env, sdk, strkey deps to compat with 22.0.0-rc.1 stream.

Also remove the env as a direct dependency.

Why

Routine, so we can bring in more upstream work on protocol 22 to start testing, etc.

The additional change to remove env as a direct dependency came about because I realised that it and the sdk are in many places an artificial dependency that don't actually serve a purpose. Once upon a time the env was a critical dependency because simulation actually occurred within the cli itself, but that was a long time ago and is no longer.

@leighmcculloch leighmcculloch marked this pull request as ready for review October 3, 2024 00:04
@leighmcculloch leighmcculloch enabled auto-merge (squash) October 3, 2024 00:11
@leighmcculloch
Copy link
Member Author

@fnando The rpc tests are failing because the rpc isn't updated yet, but all the test-wasms in this repo build with the same protocol as the cli, rather than a fixed protocol defined separately for them.

I'm thinking of taking a route similar to the env repo, where the dep graph of the test wasms is independent of the crates in the repo, and so we can build the test wasms with the previous protocol version, and the cli with the current protocol version. Whenever the rpc is released we can update the test-wasms to use the new protocol version.

If we use this pattern now and in the future it'll help us be able to update to the new protocol faster than the rpc can or in parallel with it.

@leighmcculloch leighmcculloch merged commit 8ebf6ea into main Oct 9, 2024
20 of 24 checks passed
@leighmcculloch leighmcculloch deleted the upd branch October 9, 2024 14:47
@leighmcculloch leighmcculloch mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants