#1682: fix build tests #1736
Merged
#1682: fix build tests #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
requested review from
leighmcculloch and
fnando
and removed request for
a team
Ifropc
force-pushed
the
1682-help-tests
branch
2 times, most recently
from
e4b3254 to
2b58f20
Compare
Ifropc
force-pushed
the
1682-build-tests
branch
from
40609e1 to
01e5fe1
Compare
|
I just discovered all these failing tests. Thanks for fixing them @Ifropc. cc @leighmcculloch oops... |
Ifropc
force-pushed
the
1682-build-tests
branch
from
288ac83 to
6442066
Compare
leighmcculloch
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #1682 test fixes. This PR fixes build tests.
Why
As part of #1594
CARGO_BUILD_RUSTFLAGSwere added, making existing tests to fail (ifRUSTFLAGSare not set).In addition, according to the documentation
--remap-path-prefixshould be in format--remap-path-prefix<SPACE>FROM=TOwhile in #1594 it uses format--remap-path-prefix=FROM=TOKnown limitations
Some unrelated tests fail, see #1682