Do not show hidden values in the barchart List sample label menu option results
#2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nu option results.
|
seeing this error when 'RNA-seq' from assay availability is overlaid with 'sex' in all-pharma and categories are clicked to enable hiding via the legend.
|
karishma-gangwani
approved these changes
Jan 10, 2025
| /** Don't show hidden values in the results | ||
| * May not be caught in server request for custom variables | ||
| * with user supplied keys */ | ||
| if (self.config.term.q?.hiddenValues && `${sample[self.config.term.$id].key}` in self.config.term.q.hiddenValues) |
There was a problem hiding this comment.
do you want to add additional check with optional chaining to check against the .key?
There was a problem hiding this comment.
Not really. The in operator make this safer since the string value itself could be anything: str | undefined | null
There was a problem hiding this comment.
i suggest to look into a backend fix instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes issue #2583.
Catches custom hidden variables as categories before displaying them on the client. Will send data to use for testing in All-pharmacotyping example: http://localhost:3000/?noheader=1&massnative=hg38,ALL-pharmacotyping.
Checklist
Check each task that has been performed or verified to be not applicable.