Fix rare deadlock on multiple concurrent conn.Close() calls. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 28, 2016 17:30
Return ErrClosed error if errors channel is closed (which it can only be if socket is closed too).
This will allow to use Go below 1.7
|
So this seems to fix the same issue as #196. We'll need some time to weigh the two and merge the preferred version. Thank you. |
|
@DmitriyMV OK, we will take a look at this PR earlier then. I've seen Travis failures that I cannot reproduce locally so it's not clear if the changes in #196 are to blame :( |
michaelklishin
requested changes
Dec 3, 2016
| } | ||
|
|
||
| wg := sync.WaitGroup{} | ||
| wg.Add(5) |
There was a problem hiding this comment.
When I change this value to something higher than 5, I cannot get the suite to pass 20 times in a row, e.g.
for i in {1..20}; do go test -v -tags integration_test.go .\/...; done
There was a problem hiding this comment.
Never mind, I figured it out.
michaelklishin
approved these changes
Dec 3, 2016
| } | ||
|
|
||
| wg := sync.WaitGroup{} | ||
| wg.Add(5) |
There was a problem hiding this comment.
Never mind, I figured it out.
michaelklishin
added a commit
that referenced
this pull request
Dec 3, 2016
If a connection.close operation fails before the connection is marked as closed internally, it's still a reasonable error for Connection#Close to return. Note that it only happens with a certain degree of concurrency in this test and thus the occurrence is quite unlikely in practice. References #227.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #226