Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare deadlock on multiple concurrent conn.Close() calls. #227

Merged
merged 4 commits into from
Dec 3, 2016
Merged

Fix rare deadlock on multiple concurrent conn.Close() calls. #227

merged 4 commits into from
Dec 3, 2016

Commits on Nov 28, 2016

  1. Fix rare deadlock on multiple concurrent conn.Close() calls.

    DmitriyMV committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    0ff96f5 View commit details
    Browse the repository at this point in the history

  2. Show err type on test fail

    DmitriyMV committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    11da42e View commit details
    Browse the repository at this point in the history

  3. Add check for channel in select close. 

    Return ErrClosed error if errors channel is closed (which it can only be if socket is closed too).
    DmitriyMV committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    015130c View commit details
    Browse the repository at this point in the history

  4. Use goroutines instead of testing.T.Run(). 

    This will allow to use Go below 1.7
    DmitriyMV committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    170a3e8 View commit details
    Browse the repository at this point in the history