fix: Set TEXTPLAN_SOURCE_DIR based on current dir in planloader test. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That variable was previously computed based on `CMAKE_SOURCE_DIR`, which is the wrong value if `substrait-cpp` is used as a dependency from a different top-level CMake project. The PR applies the pattern based on `CMAKE_CURRENT_SOURCE_DIR` used in other tests.
ingomueller-net
force-pushed
the
fix-planload-cmake
branch
from
b8663f5
to
907ac64
Compare
EpsilonPrime
approved these changes
Mar 14, 2024
westonpace
approved these changes
Mar 14, 2024
EpsilonPrime
changed the title
|
Thanks for the prompt approvals! Note that I don't have permissions to merge. Feel free to merge at any time... |
|
Yep, was just waiting for my CI fixes to catch up so the tests would pass. Thanks again. There hasn't been a lot of use of this as a sub project yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That variable was previously computed based on
CMAKE_SOURCE_DIR, which is the wrong value ifsubstrait-cppis used as a dependency from a different top-level CMake project. The PR applies the pattern based onCMAKE_CURRENT_SOURCE_DIRused in other tests.