Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set TEXTPLAN_SOURCE_DIR based on current dir in planloader test. #101

Merged
merged 3 commits into from
Mar 15, 2024
Merged

fix: Set TEXTPLAN_SOURCE_DIR based on current dir in planloader test. #101

merged 3 commits into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. fix: Set TEXTPLAN_SOURCE_DIR based on current dir in ploadloader test. 

    That variable was previously computed based on `CMAKE_SOURCE_DIR`, which
is the wrong value if `substrait-cpp` is used as a dependency from a
different top-level CMake project. The PR applies the pattern based on
`CMAKE_CURRENT_SOURCE_DIR` used in other tests.
    @ingomueller-net
    ingomueller-net committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    907ac64 View commit details
    Browse the repository at this point in the history

  2. Use ../ instead of cmake_path(... PARENT_PATH ...).

    @ingomueller-net
    ingomueller-net committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1b89f8a View commit details
    Browse the repository at this point in the history

  3. Fix formatting of CMake file.

    @ingomueller-net
    ingomueller-net committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a06c17b View commit details
    Browse the repository at this point in the history