Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove support for older protobuf versions #105

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feat: remove support for older protobuf versions #105

wants to merge 21 commits into from

Conversation

EpsilonPrime
Copy link
Member

No description provided.

@EpsilonPrime EpsilonPrime marked this pull request as draft July 26, 2024 00:27
@EpsilonPrime EpsilonPrime changed the title see if we can update cmake feat: remove support for older protobuf versions Jul 26, 2024
@EpsilonPrime EpsilonPrime marked this pull request as ready for review July 26, 2024 00:57
jacques-n
jacques-n approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Anytime there is more code deleted than added is a good thing from my pov!

@EpsilonPrime EpsilonPrime marked this pull request as draft November 5, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacques-n jacques-n jacques-n approved these changes

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EpsilonPrime @jacques-n