feat: remove support for older protobuf versions

.clang-tidy

@@ -77,7 +77,7 @@ Checks: >
   -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-unchecked-optional-access
 WarningsAsErrors: '*'
-HeaderFilterRegex: 'io/substrait/*.\\.h$'
+HeaderFilterRegex: 'io/substrait/.*\\.h$'
 AnalyzeTemporaryDtors: false
 FormatStyle: none
 CheckOptions:

.gitmodules

@@ -7,9 +7,6 @@
 [submodule "third_party/fmt"]
 	path = third_party/fmt
 	url = https://github.com/fmtlib/fmt
-[submodule "third_party/abseil-cpp"]
-	path = third_party/abseil-cpp
-	url = https://github.com/abseil/abseil-cpp.git
 [submodule "third_party/datetime"]
 	path = third_party/datetime
 	url = https://github.com/HowardHinnant/date.git

.licenserc.yaml

@@ -12,7 +12,6 @@ header:
     - '.clang-tidy'
     - '.cmake-format'
     - '.licenserc.yaml'
-    - 'third_party/abseil-cpp'
     - 'third_party/antlr4'
     - 'third_party/datetime'
     - 'third_party/fmt'

CMakeLists.txt

@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.24)
+cmake_minimum_required(VERSION 3.27)
 
 # set the project name
 project(substrait-cpp)
@@ -33,25 +33,16 @@ option(
 include_directories(include)
 include_directories(src)
 
-# TODO: Simplify once we can require cmake 3.27 (where CONFIG is default).
+if(${CLANG_TIDY_BUILD})
+  add_compile_options("-Wno-attributes;-Wno-deprecated-declarations")
+endif()
 
-# Due to packaging changes we use the combined protobuf/absl packaging if
-# available otherwise we fallback to the older protobuf method.
 find_package(Protobuf QUIET CONFIG)
 if(${Protobuf_FOUND})
   message(STATUS "Modern protobuf library located.")
-  set(ABSL_INCLUDED_WITH_PROTOBUF ON)
 else()
-  find_package(Protobuf QUIET)
-  if(${Protobuf_FOUND})
-    message(STATUS "Legacy protobuf library located.")
-    include_directories(${Protobuf_INCLUDE_DIRS})
-    set(ABSL_INCLUDED_WITH_PROTOBUF OFF)
-  else()
-    message(STATUS "Fetching external protobuf library.")
-    include(third_party/protobuf.cmake)
-    set(ABSL_INCLUDED_WITH_PROTOBUF ON)
-  endif()
+  message(STATUS "Fetching external protobuf library.")
+  include(third_party/protobuf.cmake)
 endif()
 
 add_subdirectory(third_party)

scripts/run-clang-tidy.sh

@@ -3,15 +3,20 @@
 SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 WORKDIR="$( cd $SCRIPTDIR/.. && pwd )"
 
-# Make compile_command.json
-rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_ROUNDTRIP_TESTING=ON
-# Build substrait protobuf
-pushd tmp/src/substrait/proto && make -j && popd || exit
-# Build textplan grammar
+set -o errexit
+
+echo Making compile_command.json
+rm -rf tmp && mkdir tmp && cmake -Btmp -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DSUBSTRAIT_CPP_BUILD_TESTING=OFF -DCLANG_TIDY_BUILD=ON
+echo Building substrait protobuf
+pushd tmp/src/substrait/proto
+make -j
+popd
+echo Building textplan grammar
 pushd tmp/src/substrait/textplan/parser/grammar && make -j antlr4_runtime textplan_grammar_headers && popd || exit
-# Run clang-tidy
+echo Running clang-tidy
 if [ "$1" == "fix" ]; then
    python3 scripts/run-clang-tidy.py "$WORKDIR" "tmp" "third_party" "h,hpp,cc,cpp" "--quiet --fix"
 else
    python3 scripts/run-clang-tidy.py "$WORKDIR" "tmp" "third_party" "h,hpp,cc,cpp" "--quiet"
 fi
+echo Finished running clang-tidy

third_party/CMakeLists.txt

@@ -4,10 +4,6 @@
 set(CMAKE_POLICY_DEFAULT_CMP0077 NEW)
 
 set(ABSL_ENABLE_INSTALL ON)
-if(NOT ${ABSL_INCLUDED_WITH_PROTOBUF})
-  set(ABSL_PROPAGATE_CXX_STD ON)
-  add_subdirectory(abseil-cpp)
-endif()
 
 include(datetime.cmake)