Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't concatenate paths in --proto_path #109

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Don't concatenate paths in --proto_path #109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa89232
Don't concatenate paths in `--proto_path`
mortbopet Sep 3, 2024
50f5e1b
format
mortbopet Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/substrait/proto/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ foreach(PROTO_FILE IN LISTS PROTOBUF_FILELIST)
OUTPUT ${PROTO_SRC} ${PROTO_HDR}
COMMAND
protobuf::protoc
"--proto_path=${GENERATED_PROTO_TOPLEVEL_DIR}:${protobuf_SOURCE_DIR}/src"
"--proto_path=${GENERATED_PROTO_TOPLEVEL_DIR}"
"--proto_path=${protobuf_SOURCE_DIR}/src"
"--cpp_out=${PROTO_OUTPUT_MIDLEVEL_DIR}" ${GENERATED_PROTO_FILE}
DEPENDS ${GENERATED_PROTOBUF_LIST} protobuf::protoc
COMMENT "Generated C++ protobuf module for ${PROTO_FILE}"
Expand Down
Loading