Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ANTLR4CPP_STATIC for everything that links against ANTLR #112

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Set ANTLR4CPP_STATIC for everything that links against ANTLR #112

merged 1 commit into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. Set ANTLR4CPP_STATIC for everything that links against ANTLR 

    It isn't sufficient to rely on a single [`add_definitions`](https://github.com/substrait-io/substrait-cpp/blob/cc8d08af7a7ff4b65d0081fc18f9bb243fe85824/src/substrait/textplan/parser/grammar/CMakeLists.txt#L8) when defining this. Other things which pulls in ANTLR headers _must_ define this as well - if not, we end up with very hard to debug symbol visibility errors.

Set it as a public compile definition on the target to ensure the definition propagates.
    @mortbopet
    mortbopet committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    be3d6f9 View commit details
    Browse the repository at this point in the history