Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ANTLR4CPP_STATIC for everything that links against ANTLR #112

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/substrait/textplan/parser/grammar/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,9 @@ target_include_directories(

target_link_libraries(textplan_grammar antlr4_static)

# Things which link against textplan_grammar (and pull in antlr4 headers) should
# always set 'ANTLR4CPP_STATIC', to avoid declaring things in the antlr4
# headers as dllexport'ed.
target_compile_definitions(textplan_grammar PUBLIC ANTLR4CPP_STATIC)

install(TARGETS textplan_grammar EXPORT SubstraitTargets)
Loading