Don't define member functions inside a nested namespace #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trips up MSVC, in that member functions aren't properly included in the object files of the various translation units. Generally, this should be fixed by having a `using` declaration in a .cpp file. From my experience, a general good practice is to never nest definitions in namespaces, unless that is only visible from within a translation unit (e.g. a `detail` namespace inside a .cpp file). This doesn't fix all of the places in the code where this pattern is used - only the (narrow) compile path that i've been excercising. Someone should probably go through the rest of the codebase and apply this - will be needed if/when a windows CI pipeline is added.
EpsilonPrime
reviewed
Sep 5, 2024
| @@ -12,7 +12,7 @@ | |||
| #include "substrait/textplan/Location.h" | |||
| #include "substrait/textplan/StructuredSymbolData.h" | |||
|
|
|||
| namespace io::substrait::textplan { | |||
There was a problem hiding this comment.
Would changing this to three separate namespace definitions did the problem?
There was a problem hiding this comment.
It's hard to find documentation about this (it's sort of a bug-in-limbo...). I'm not at my workstation at the moment so i can't give an answer now, but my hunch would be no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trips up MSVC, in that member functions aren't properly included in the object files of the various translation units.
e.g.
DumpBinofsymbol_table.lib:Generally, this can be fixed by having a
usingdeclaration in a .cpp file to enable the namespace. From my experience, a general good practice is to never nest definitions in namespaces, unless the namespace is only visible from within a translation unit (e.g. adetailnamespace inside a .cpp file).This doesn't fix all of the places in the code where this pattern is used - only the (narrow) compile path that i've been excercising. Someone should probably go through the rest of the codebase and apply this - will be needed if/when a windows CI pipeline is added.