Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't define member functions inside a nested namespace #113

Closed
wants to merge 2 commits into from
Closed

Don't define member functions inside a nested namespace #113

wants to merge 2 commits into from

Commits on Sep 5, 2024

  1. Don't define member functions inside a nested namespace 

    This trips up MSVC, in that member functions aren't properly included in the object files of the various translation units. Generally, this should be fixed by having a `using` declaration in a .cpp file. From my experience, a general good practice is to never nest definitions in namespaces, unless that is only visible from within a translation unit (e.g. a `detail` namespace inside a .cpp file).

This doesn't fix all of the places in the code where this pattern is used - only the (narrow) compile path that i've been excercising. Someone should probably go through the rest of the codebase and apply this - will be needed if/when a windows CI pipeline is added.
    @mortbopet
    mortbopet committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    163f2d2 View commit details
    Browse the repository at this point in the history

  2. explicit namespace for free function

    @mortbopet
    mortbopet committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1e1e508 View commit details
    Browse the repository at this point in the history