Fix namespace pollution on Windows #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpsilonPrime
reviewed
Sep 7, 2024
src/substrait/common/CMakeLists.txt
Outdated
| @@ -21,8 +21,8 @@ add_dependencies( | |||
| target_include_directories( | |||
| substrait_io | |||
| INTERFACE | |||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../../include/substrait/common> | |||
| $<INSTALL_INTERFACE:include/substrait/common>) | |||
| $<BUILD_INTERFACE:${SUBSTRAIT_CPP_INCLUDE_DIR}> | |||
There was a problem hiding this comment.
The linter is complaining here since the lines are so short. (It wants to use two lines instead of three.)
EpsilonPrime
approved these changes
Sep 7, 2024
As described in substrait-io#116, the `io.h` file in this project conflicts with `io.h` of windows. This fixes that (in the somewhat narrow compilation path that i'm exercising) by removing `include/substrait/common` from the include path, and instead relying on the (already existing) full include-path namespacing instead of relative includes of `io.h`.
mortbopet
force-pushed
the
dev/mpetersen/io_namespace_pollution
branch
from
f7e538f
to
bd445e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #116, the
io.hfile in this project conflicts withio.hof windows.This fixes that (in the somewhat narrow compilation path that i'm exercising) by removing
include/substrait/commonfrom the include path, and instead relying on the (already existing) full include-path namespacing instead of relative includes ofio.h.