Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace pollution on Windows #117

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix namespace pollution on Windows #117

merged 2 commits into from
Sep 7, 2024

Commits on Sep 7, 2024

  1. Fix namespace pollution on Windows 

    As described in substrait-io#116, the `io.h` file in this project conflicts with `io.h` of windows.

This fixes that (in the somewhat narrow compilation path that i'm exercising) by removing `include/substrait/common` from the include path, and instead relying on the (already existing) full include-path namespacing instead of relative includes of `io.h`.
    @mortbopet
    mortbopet committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    cddd023 View commit details
    Browse the repository at this point in the history

  2. format

    @mortbopet
    mortbopet committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    bd445e8 View commit details
    Browse the repository at this point in the history