More windows-related fixes #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `!` instead of a `not` macro - Don't build the `planparser` tool on windows; this uses unix commands to parse arguments. - std::filesystem::path doesn't implicitly convert to std::string on msvc - A shared library must specify export symbols (or set `CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS`) for a .lib file to be generated, which is required for things to link against said library. - Can't use `*` (wildcard) on windows in a CMake command; use built-in CMake globbing instead.
EpsilonPrime
approved these changes
Oct 10, 2024
mortbopet
force-pushed
the
dev/mpetersen/windows_fixes
branch
from
ee152e6
to
318ff22
Compare
|
@EpsilonPrime Awesome... might need some help with this PR wrt. getting CI to pass. Build/test is passing, but for some reason, |
Looks like the runner is getting killed. Maybe it's running out of memory? Can you try to reduce the parallelism here: ? |
|
@mbrobbel thanks for the tip - reduced to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!instead of anotmacroplanparsertool on windows; this uses unix commands to parse arguments.CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS) for a .lib file to be generated, which is required for things to link against said library.*(wildcard) on windows in a CMake command; use built-in CMake globbing instead.Also requires EpsilonPrime/protobuf-matchers@91968ca to land.