Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More windows-related fixes #126

Merged
merged 9 commits into from
Oct 11, 2024

Commits on Oct 10, 2024

  1. More windows-related nits

    - use `!` instead of a `not` macro
    - Don't build the `planparser` tool on windows; this uses unix commands to parse arguments.
    - std::filesystem::path doesn't implicitly convert to std::string on msvc
    - A shared library must specify export symbols (or set `CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS`) for a .lib file to be generated, which is required for things to link against said library.
    - Can't use `*` (wildcard) on windows in a CMake command; use built-in CMake globbing instead.
    mortbopet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    aa44efc View commit details
    Browse the repository at this point in the history
  2. bump protobuf

    mortbopet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0d6fa10 View commit details
    Browse the repository at this point in the history
  3. format

    mortbopet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6b2aea1 View commit details
    Browse the repository at this point in the history
  4. protobuf related change

    mortbopet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fb8b7cd View commit details
    Browse the repository at this point in the history
  5. format

    mortbopet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f14fa78 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. bump protobuf-matchers tag

    mortbopet committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7a8e874 View commit details
    Browse the repository at this point in the history
  2. Bump protobuf version in CI

    mortbopet committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    318ff22 View commit details
    Browse the repository at this point in the history
  3. try fix gtest

    mortbopet committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ab6bf26 View commit details
    Browse the repository at this point in the history
  4. reduce parallelism

    mortbopet committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    646ab61 View commit details
    Browse the repository at this point in the history