-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More windows-related fixes #126
Merged
EpsilonPrime
merged 9 commits into
substrait-io:main
from
mortbopet:dev/mpetersen/windows_fixes
Oct 11, 2024
Merged
More windows-related fixes #126
EpsilonPrime
merged 9 commits into
substrait-io:main
from
mortbopet:dev/mpetersen/windows_fixes
Oct 11, 2024
Commits on Oct 10, 2024
-
- use `!` instead of a `not` macro - Don't build the `planparser` tool on windows; this uses unix commands to parse arguments. - std::filesystem::path doesn't implicitly convert to std::string on msvc - A shared library must specify export symbols (or set `CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS`) for a .lib file to be generated, which is required for things to link against said library. - Can't use `*` (wildcard) on windows in a CMake command; use built-in CMake globbing instead.
Configuration menu - View commit details
-
Copy full SHA for aa44efc - Browse repository at this point
Copy the full SHA aa44efcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d6fa10 - Browse repository at this point
Copy the full SHA 0d6fa10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2aea1 - Browse repository at this point
Copy the full SHA 6b2aea1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb8b7cd - Browse repository at this point
Copy the full SHA fb8b7cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f14fa78 - Browse repository at this point
Copy the full SHA f14fa78View commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a8e874 - Browse repository at this point
Copy the full SHA 7a8e874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 318ff22 - Browse repository at this point
Copy the full SHA 318ff22View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab6bf26 - Browse repository at this point
Copy the full SHA ab6bf26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 646ab61 - Browse repository at this point
Copy the full SHA 646ab61View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.