ci: check for unstaged files #1685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
ci/check-unstaged-changes
branch
3 times, most recently
from
68a00cc to
c3544d7
Compare
roschaefer
commented
Sep 5, 2023
.tool-versions
Outdated
| @@ -1,3 +1,3 @@ | |||
| ruby 3.0.0 | |||
| nodejs lts-erbium | |||
| nodejs 12.22.12 | |||
There was a problem hiding this comment.
So this was necessary for the Github action marocchino/tool-versions-action to work. However it is now considered bad practice to set codename versions: https://github.com/asdf-vm/asdf-nodejs#partial-and-codename-versions
There was a problem hiding this comment.
$ asdf nodejs resolve lts-erbium --latest-available
12.22.12
When you do the following ``` $ asdf install $ npm --version 6.14.16 ``` and run: ``` npm install ``` ~then you get a changed `package-lock.json`.~ It is good practice to always check in lock files into version control. On CI we run `npm install` (among other things). If we make sure that we do not leave any updates files, this ensures we always commit our lock files. EDIT: You don't, my fault. But it does not hurt to merge this PR anyways.
roschaefer
force-pushed
the
ci/check-unstaged-changes
branch
from
c3544d7 to
d6216db
Compare
mattwr18
reviewed
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you do the following
and run:
then you get a changedpackage-lock.json.It is good practice to always check in lock files into version control.
On CI we run
npm install(among other things). If we make sure that wedo not leave any updates files, this ensures we always commit our lock
files.
EDIT: You don't, my fault. But it does not hurt to merge this PR anyways.