Remove data migrations workflow/gem #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These data migrations are meant to be run on production instances where we need to manipulate the data once and not to be run when setting up new instances. Also, if we skip a deploy on specific instances for some reason, which is not ideal, but does happen, there are too many considerations to be ideal. We have a PR to make them more idempotent, but even so the first ones were written when all instances were single tenant and we could be sure there was only one organization, but after introducing multi-tenancy, there is another layer that must be considered.
roschaefer
force-pushed
the
remove_data_migrations
branch
from
5122b6a to
11d7c2a
Compare
mattwr18
added a commit
that referenced
this pull request
Sep 27, 2024
These data migrations are meant to be run on production instances where we need to manipulate the data once and not to be run when setting up new instances. Also, if we skip a deploy on specific instances for some reason, which is not ideal, but does happen, there are too many considerations to be ideal. We have a PR to make them more idempotent, but even so the first ones were written when all instances were single tenant and we could be sure there was only one organization, but after introducing multi-tenancy, there is another layer that must be considered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These data migrations are meant to be run on production instances where we need to manipulate the data once and not to be run when setting up new instances. Also, if we skip a deploy on specific instances for some reason, which is not ideal, but does happen, there are too many considerations to be ideal.
We have a PR to make them more idempotent, but even so the first ones were written when all instances were single tenant and we could be sure there was only one organization, but after introducing multi-tenancy, there is another layer that must be considered.