-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imageio dependencies for pypi wheel #1950
Conversation
WalkthroughThe pull request introduces two new dependencies, Changes
Possibly related PRs
Poem
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
pypi_requirements.txt (2)
9-9
: Approve the addition ofimageio
, but consider specifying a version range.The addition of
imageio
is consistent with the PR objectives and expands the project's image processing capabilities.However, to ensure compatibility and avoid potential issues in the future, consider specifying a version range for
imageio
. For example:-imageio +imageio>=2.22.0,<3.0.0
10-10
: Approve the addition ofimageio-ffmpeg
, but consider specifying a version range.The addition of
imageio-ffmpeg
is consistent with the PR objectives and expands the project's video processing capabilities.However, to ensure compatibility and avoid potential issues in the future, consider specifying a version range for
imageio-ffmpeg
. For example:-imageio-ffmpeg +imageio-ffmpeg>=0.4.0,<1.0.0
Description
In #1943, we added missing
imageio-ffmpeg
dependencies for the conda package.The PR adds the missing
imageio-ffmpeg
dependencies for the PyPI wheels. This was already don in #1841 separately, but should be applied to all branches that it affects (i.e. also develop).Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
imageio
andimageio-ffmpeg
, ensuring enhanced multimedia content handling.