chore: remove subtle feature
#6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 39m 8s ⏱️ Results for commit c0a928c. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)29 tests 29 ✅ 11m 52s ⏱️ Results for commit c0a928c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the
core_hint_black_boxfeature fromsubtle.Motivation and Context
We currently use the
core_hint_black_boxfeature fromsubtle, which uses a particular optimization barrier.However, the standard library documentation cautions against the use of
std::hint::black_boxfor cryptographic use. This has ledsubtleto remove it in an upcoming release, at which point the feature will do nothing.This PR takes the proactive step of removing the feature. There is still an optimization barrier in place, which will become the default after the feature is deprecated.
How Has This Been Tested?
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
Check the claims made in the PR about the feature behavior.