Editorial: Fix old bug in Annex B's changes to FunctionDeclarationInstantiation #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec.html
Outdated
| @@ -50961,7 +50961,7 @@ <h1>Changes to FunctionDeclarationInstantiation</h1> | |||
| <p>During FunctionDeclarationInstantiation the following steps are performed in place of step <emu-xref href="#step-functiondeclarationinstantiation-web-compat-insertion-point"></emu-xref>:</p> | |||
| <emu-alg replaces-step="step-functiondeclarationinstantiation-web-compat-insertion-point"> | |||
| 1. If _strict_ is *false*, then | |||
| 1. For each |FunctionDeclaration| _f_ that is directly contained in the |StatementList| of a |Block|, |CaseClause|, or |DefaultClause|, do | |||
| 1. For each |FunctionDeclaration| _f_ that is directly contained in the |StatementList| of a |Block|, |CaseClause|, or |DefaultClause| Contained within _code_, do | |||
There was a problem hiding this comment.
In the editor call, we decided that we would prefer the form ... any |Block|, |CaseClause|, or |DefaultClause| _x_ such that _code_ Contains _x_ is *true* that you mentioned. We will explore dropping the is *true* from here and in other places in #3370.
We should also update the two existing uses of Contained within in B.3.2.2 and B.3.2.3 to match this phrasing.
There was a problem hiding this comment.
Added a commit to accomplish this.
…tantiation This PR completes a small bugfix from 9 years ago. Fixes tc39#2663. ---- History: 2015-07-17: @bakkot identifies a problem in Annex B's "Changes to FunctionDeclarationInstantiation": https://esdiscuss.org/topic/block-level-function-declarations-web-legacy-compatibility-bug To remedy this, @allenwb submits bug 4427: https://tc39.es/archives/bugzilla/4427/ in which he recommends changing > For each FunctionDeclaration _f_ **in _varDeclarations_** that is directly contained in the |StatementList| of a |Block|, |CaseClause|, or |DefaultClause|, to > For each FunctionDeclaration _f_ that is directly contained in the |StatementList| of a |Block|, |CaseClause|, or |DefaultClause| **Contained within _code_**, (emphasis mine). 2015-10-29: @anba submits PR tc39#141, claiming to fix bug 4427. It deletes "in _varDeclarations_", but doesn't add "Contained within _code_". My guess is, this was just an oversight. 2015-11-02: PR tc39#141 is merged to master as commit efbfc88. 2022-02-13: @nicolo-ribaudo raises issue tc39#2663 about this, and says he'd open a PR to fix it, but I don't think that happened. 2024-06-26: @gibson042 raises the problem again, in a commment on PR tc39#2952: tc39#2952 (comment)
Change the 3 occurrences of
a |Block|, |CaseClause|, or |DefaultClause| Contained within _code_
to
any |Block|, |CaseClause|, or |DefaultClause| _x_ such that _code_ Contains _x_ is *true*
(See tc39#2663 (comment))
jmdyck
force-pushed
the
Contained_within_code
branch
from
e16c929
to
e1399d7
Compare
michaelficarra
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes a small bugfix from 9 years ago.
Fixes #2663.
History:
2015-07-17:
@bakkot identifies a problem in Annex B's
"Changes to FunctionDeclarationInstantiation":
https://esdiscuss.org/topic/block-level-function-declarations-web-legacy-compatibility-bug
To remedy this, @allenwb submits bug 4427:
https://tc39.es/archives/bugzilla/4427/
in which he recommends changing
to
(emphasis mine).
2015-10-29:
@anba submits PR #141, claiming to fix bug 4427.
It deletes "in varDeclarations", but doesn't add "Contained within code".
My guess is, this was just an oversight.
2015-11-02:
PR #141 is merged to master as commit efbfc88.
2022-02-13:
@nicolo-ribaudo raises issue #2663 about this,
and says he'd open a PR to fix it, but I don't think that happened.
2024-06-26:
@gibson042 raises the problem again, in a commment on PR #2952:
#2952 (comment)