Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix old bug in Annex B's changes to FunctionDeclarationInstantiation #3361

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Editorial: Fix old bug in Annex B's changes to FunctionDeclarationInstantiation #3361

merged 2 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. Editorial: Fix old bug in Annex B's changes to FunctionDeclarationIns… 

    …tantiation (tc39#3361)

This PR completes a small bugfix from 9 years ago.

Fixes tc39#2663.

----

History:

2015-07-17:
@bakkot identifies a problem in Annex B's
"Changes to FunctionDeclarationInstantiation":
https://esdiscuss.org/topic/block-level-function-declarations-web-legacy-compatibility-bug

To remedy this, @allenwb submits bug 4427:
https://tc39.es/archives/bugzilla/4427/
in which he recommends changing
> For each FunctionDeclaration _f_ **in _varDeclarations_** that is directly contained in the |StatementList| of a |Block|, |CaseClause|, or |DefaultClause|,

to
> For each FunctionDeclaration _f_ that is directly contained in the |StatementList| of a |Block|, |CaseClause|, or |DefaultClause| **Contained within _code_**,

(emphasis mine).

2015-10-29:
@anba submits PR tc39#141, claiming to fix bug 4427.
It deletes "in _varDeclarations_",
but doesn't add "Contained within _code_".
My guess is, this was just an oversight.

2015-11-02:
PR tc39#141 is merged to master as commit efbfc88.

2022-02-13:
@nicolo-ribaudo raises issue tc39#2663 about this,
and says he'd open a PR to fix it,
but I don't think that happened.

2024-06-26:
@gibson042 raises the problem again, in a commment on PR tc39#2952:
tc39#2952 (comment)
    @jmdyck @ljharb
    jmdyck authored and ljharb committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5885b6c View commit details
    Browse the repository at this point in the history

  2. Editorial: Eliminate "Contained within" (tc39#3361) 

    Change the 3 occurrences of
    a |Block|, |CaseClause|, or |DefaultClause| Contained within _code_
to
    any |Block|, |CaseClause|, or |DefaultClause| _x_ such that _code_ Contains _x_ is *true*

(See tc39#2663 (comment))
    @jmdyck @ljharb
    jmdyck authored and ljharb committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f2b2d52 View commit details
    Browse the repository at this point in the history