-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis to GitHub Actions. #452
Conversation
The result of a CI test run can be seen here: https://github.com/jason-fox/iotagent-ul/actions/runs/380925209 |
Music to my ears xD |
Is there a way to so the result of the action "inline" the PR? I mean something like Travis does: or |
Yes, it will display in the same manner once the PR is merged. Here is a working FIWARE example: https://github.com/FIWARE/iotagent-isoxml |
Thanks for the clarifications! Btw, maybe this other repository should also be de-travis-ed ? https://github.com/telefonicaid/lightweightm2m-iotagent |
Probably, but unlike all of the other repos, the Unit-Tests for LWM2M have not been updated to use mocks properly so the set-up for the GitHub Actions would be much more complex. I haven't got time for that. I'm starting off by picking the low hanging fruit from 50+ FIWARE catalogue projects first. I'm running through the easy Node.js stuff first then Java then Python. Your biggest concern should be converting repos that eat into your free minutes like: https://github.com/telefonicaid/fiware-orion LWM2M isn't very active so it can wait. |
Ok, makes sense. IOTA LWM2M can wait.
You are right. Currently, the functional testing sub-job in Orion takes around 40-50 minutes (even with some "hacks" to reduce the time of some test cases, such this one), very close to the the travis timeout. Have github actions some similar timeout? Lower or higher than travis? |
So six hours. |
Great. That means that the functional testing sub-job in Orion will fit even better in git actions than in travis :) |
Noted for IOTA-LWM2M: telefonicaid/lightweightm2m-iotagent#235 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As I'm sure you are aware from the TSC minutes, it appears that Travis is transitioning towards a paid pricing model. It would be opportune for active FOSS Projects to migrate to use the integrated GitHub Actions. It looks like each GitHub account is safe until January, but then
travis-ci.org
goes read-only then the 100000 credits start counting down. There is no clarity over if/how to obtain more credits, and indeed if they can be obtained in a timely manner.Background links
This PR sets up the equivalent GitHub Action CI to the old Travis Yaml and as a bonus, the flaky AMPQ test. seems to work.