Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external tcp attached to kinematic link #497

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Dec 31, 2020

This finishes out support for external tcp to support all examples in tesseract_ros_examples.

The last commit addresses issue #498.

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (feature/CommandLanguage@c36118e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##             feature/CommandLanguage     #497   +/-   ##
==========================================================
  Coverage                           ?   70.44%           
==========================================================
  Files                              ?      219           
  Lines                              ?    14056           
  Branches                           ?        0           
==========================================================
  Hits                               ?     9902           
  Misses                             ?     4154           
  Partials                           ?        0           

@Levi-Armstrong Levi-Armstrong force-pushed the feature/ExternalTCPKinematicLink branch from bb8e660 to 5e7450d Compare December 31, 2020 05:02
@Levi-Armstrong
Copy link
Contributor Author

@mpowelson The latest commit reverts changes and adds asserts. It now only formats the program when a request is submitted to the planning server.

@Levi-Armstrong Levi-Armstrong force-pushed the feature/ExternalTCPKinematicLink branch 3 times, most recently from 519112e to ba0cfda Compare December 31, 2020 23:14
@Levi-Armstrong
Copy link
Contributor Author

@mpowelson You good with me merging this?

@Levi-Armstrong Levi-Armstrong force-pushed the feature/ExternalTCPKinematicLink branch 3 times, most recently from b575f27 to f12dce7 Compare January 3, 2021 18:51
@Levi-Armstrong Levi-Armstrong merged commit e9d6289 into tesseract-robotics:feature/CommandLanguage Jan 3, 2021
@Levi-Armstrong Levi-Armstrong deleted the feature/ExternalTCPKinematicLink branch January 3, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants