Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for posey_split keyboards #2201

Merged
merged 9 commits into from
Mar 31, 2024
Merged

Conversation

joliverMI
Copy link
Contributor

@joliverMI joliverMI commented Mar 21, 2024

Adding posey_split layouts to VIA

Description

Adding support for version 4 and 5 of posey_split.

This keyboard has a hardware repeat function that can be customized by users in VIA.
The LED colors indicate which type of layer is active and if caps is activated. Those colors can be selected by users using VIA as well.

QMK Pull Request

qmk/qmk_firmware#23258

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@joliverMI joliverMI changed the title Dev branch Add support for posey_split keyboards Mar 27, 2024
@joliverMI joliverMI marked this pull request as ready for review March 27, 2024 22:01
@joliverMI
Copy link
Contributor Author

@Cipulot I'm trying to figure out how to get the checks to run on my PR. Not trying to rush you! Just noticed this PR didn't have a checkmark.

@Cipulot
Copy link
Collaborator

Cipulot commented Mar 31, 2024

@joliverMI I'll look at the PR now and suggest changes if needed, otherwise I'll run the checks and merge 👍

src/pmk/posey_split/v4/posey_split_v4.json Outdated Show resolved Hide resolved
src/pmk/posey_split/v5/posey_split_v5.json Outdated Show resolved Hide resolved
@Cipulot
Copy link
Collaborator

Cipulot commented Mar 31, 2024

@joliverMI pull the latest changes that I pushed and then please move the files from the 'src' folder to the 'v3' folder. being this a new board and not a legacy one it is mandatory to use the V3 defines.

src is the legacy folder. Moving to the appropriate newer V3 folder.
@joliverMI joliverMI requested a review from Cipulot March 31, 2024 17:42
@Cipulot Cipulot merged commit 3f90eda into the-via:master Mar 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants